Bug 229392

Summary:

The simple text codepath does not handle unpaired surrogates

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

changseok, esprehn+autocc, ews-watchlist, glenn, heycam, kondapallykalyan, pdr, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=271691

Bug Depends on:

Bug Blocks:

206208

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none

Myles C. Maxfield

Reported 2021-08-23 00:32:42 PDT

The simple text codepath does not handle unpaired surrogates

Attachments
Patch (13.47 KB, patch) 2021-08-23 00:34 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (13.96 KB, patch) 2021-08-23 00:39 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (16.44 KB, patch) 2021-08-23 01:22 PDT, Myles C. Maxfield	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (16.45 KB, patch) 2021-08-23 01:27 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (23.66 KB, patch) 2021-08-27 01:05 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2021-08-23 00:34:26 PDT

Created attachment 436156 [details] Patch

Myles C. Maxfield

Comment 2 2021-08-23 00:39:00 PDT

Created attachment 436157 [details] Patch

Myles C. Maxfield

Comment 3 2021-08-23 00:49:44 PDT

Comment on attachment 436156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436156&action=review > Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.h:60 > bool consumeSlowCase(UChar32&, unsigned&); This should be deleted

Myles C. Maxfield

Comment 4 2021-08-23 01:00:56 PDT

Comment on attachment 436156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436156&action=review > Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.h:22 > #ifndef SurrogatePairAwareTextIterator_h > #define SurrogatePairAwareTextIterator_h I can probably do #pragma once too

Myles C. Maxfield

Comment 5 2021-08-23 01:06:40 PDT

It looks like there are some usages of SurrogatePairAwareTextIterator outside of the Cocoa ports.

Myles C. Maxfield

Comment 6 2021-08-23 01:22:53 PDT

Created attachment 436161 [details] Patch

Myles C. Maxfield

Comment 7 2021-08-23 01:27:00 PDT

Created attachment 436162 [details] Patch

Myles C. Maxfield

Comment 8 2021-08-27 01:05:23 PDT

Created attachment 436611 [details] Patch