Bug 231010

Summary: Cocoa GraphicsContextGLOpenGL should not be used by GraphicsContextGLCVANGLE
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, luiz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 226504, 231009    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kimmo Kinnunen
Reported 2021-09-30 01:30:51 PDT
Cocoa GraphicsContextGLOpenGL should not be used by GraphicsContextGLCVANGLE. Makes it more complex to develop features related to compositor platform layers, as GraphicsContextGLOpenGL "draws to" a platform layer but GraphicsContextGLCVANGLE shouldn't have one.
Attachments
Patch (58.82 KB, patch)
2021-09-30 06:33 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (58.55 KB, patch)
2021-09-30 07:05 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (58.54 KB, patch)
2021-09-30 10:01 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-09-30 06:33:30 PDT
Created attachment 439731 [details] Patch
Kimmo Kinnunen
Comment 2 2021-09-30 07:05:14 PDT
Created attachment 439732 [details] Patch
Kimmo Kinnunen
Comment 3 2021-09-30 10:01:05 PDT
Created attachment 439747 [details] Patch
Kenneth Russell
Comment 4 2021-09-30 12:00:16 PDT
Comment on attachment 439747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439747&action=review Since the underlying ANGLE context relationships haven't changed - still creating a separate shared context for video uploads, with the same parameters - this looks good to me. Agree this is just a refactor. The win failure looks like an unrelated flake. r+ > Source/WebCore/platform/graphics/cocoa/ANGLEUtilitiesCocoa.h:37 > +void* createPbufferAndAttachIOSurface(EGLDisplay, EGLConfig, GLenum target, EGLint usageHint, GLenum internalFormat, GLsizei width, GLsizei height, GLenum type, IOSurfaceRef, GLuint plane); Would it be helpful to put these two free functions in another namespace or as static methods on a class, just to have a little better scoping?
EWS
Comment 5 2021-10-01 05:53:57 PDT
Committed r283362 (242371@main): <https://commits.webkit.org/242371@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439747 [details].
Radar WebKit Bug Importer
Comment 6 2021-10-01 05:54:31 PDT
<rdar://problem/83762759>
Note You need to log in before you can comment on or make changes to this bug.