Bug 231722

Summary: Remove useless isConnected() check from HTMLDialogElement::close()
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: DOMAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84635, 227537    
Attachments:
Description Flags
Patch none

Tim Nguyen (:ntim)
Reported 2021-10-13 22:33:02 PDT
https://webkit-search.igalia.com/webkit/source/Source/WebCore/html/HTMLDialogElement.cpp#98 There is already an early return in Element::focus when the element is not connected, so this check is redundant. See comment 25 in bug 227537.
Attachments
Patch (1.52 KB, patch)
2021-10-13 23:00 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1 2021-10-13 23:00:21 PDT
Created attachment 441185 [details] Patch
EWS
Comment 2 2021-10-14 00:04:12 PDT
Committed r284149 (242969@main): <https://commits.webkit.org/242969@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441185 [details].
Radar WebKit Bug Importer
Comment 3 2021-10-14 00:05:15 PDT
<rdar://problem/84236051>
Note You need to log in before you can comment on or make changes to this bug.