Bug 232707

Summary: [GTK][a11y] Add implementation of hyperlink interface when building with ATSPI
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, aperez, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, mifenton, samuel_white
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 232300, 232622    
Bug Blocks: 230253, 232708    
Attachments:
Description Flags
Patch
none
Patch
none
Patch aperez: review+, aperez: commit-queue-

Carlos Garcia Campos
Reported 2021-11-04 03:47:01 PDT
Implement hyperlink
Attachments
Patch (26.31 KB, patch)
2021-11-04 06:00 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (26.30 KB, patch)
2021-11-18 04:39 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (27.35 KB, patch)
2021-11-18 04:52 PST, Carlos Garcia Campos 		aperez: review+
aperez: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-11-04 06:00:24 PDT
Created attachment 443298 [details] Patch This won't apply because it depends on other bugs not fixed yet.
Carlos Garcia Campos
Comment 2 2021-11-18 04:39:19 PST
Created attachment 444661 [details] Patch
Carlos Garcia Campos
Comment 3 2021-11-18 04:52:17 PST
Created attachment 444662 [details] Patch
Adrian Perez
Comment 4 2021-11-18 06:23:26 PST
Comment on attachment 444662 [details] Patch Patch LGTM with a nit. Please apply the suggestion below before landing :) View in context: https://bugs.webkit.org/attachment.cgi?id=444662&action=review > Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp:499 > + if (--index == -1) This modifies “index“ in place, which made me wonder “why, and where is the modified value used later?“. But then it's not used again at all. So I would prefer to have this check written this way for readability: if (index == 0) =)
Carlos Garcia Campos
Comment 5 2021-11-19 00:52:04 PST
Committed r286050 (244437@main): <https://commits.webkit.org/244437@main>
Note You need to log in before you can comment on or make changes to this bug.