Bug 236965

Summary: After losing context due to too many contexts, getError() does not return CONTEXT_LOST_WEBGL
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 236964    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kimmo Kinnunen
Reported 2022-02-21 03:44:14 PST
After losing context due to too many contexts, getError() does not return CONTEXT_LOST_WEBGL
Attachments
Patch (33.17 KB, patch)
2022-03-17 12:01 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (20.77 KB, patch)
2022-03-22 07:02 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (22.20 KB, patch)
2022-03-22 07:10 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-28 03:45:26 PST
<rdar://problem/89550905>
Kimmo Kinnunen
Comment 2 2022-03-17 12:01:38 PDT
Created attachment 454999 [details] Patch
Kimmo Kinnunen
Comment 3 2022-03-22 07:02:49 PDT
Created attachment 455371 [details] Patch
Kimmo Kinnunen
Comment 4 2022-03-22 07:10:12 PDT
Created attachment 455373 [details] Patch
Kenneth Russell
Comment 5 2022-03-22 17:17:36 PDT
Comment on attachment 455373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455373&action=review Seems fine given that the tests progress. If it's possible to add more WebGL conformance tests covering this area, please do. r+ > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:7754 > + ASSERT_NOT_REACHED(); Just checking - this assert is not hit if the WEBGL_lose_context extension is used incorrectly? (restoreContext() is called, but preventDefault() wasn't called against the lost context event?) I assume that WEBGL_lose_context's validation will catch this misuse - and that the EWS bots are running enough WebGL conformance tests using the WEBGL_lose_context extension.
Kimmo Kinnunen
Comment 6 2022-03-23 09:38:39 PDT
Comment on attachment 455373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455373&action=review thanks fro spending the time! > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:6489 > return; this should prevent the case of calling lose_context.restoreContext() without preventDefault() >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:7754 >> + ASSERT_NOT_REACHED(); > > Just checking - this assert is not hit if the WEBGL_lose_context extension is used incorrectly? (restoreContext() is called, but preventDefault() wasn't called against the lost context event?) I assume that WEBGL_lose_context's validation will catch this misuse - and that the EWS bots are running enough WebGL conformance tests using the WEBGL_lose_context extension. Yeah, that's the intention. E.g. the timer invocation to call maybeRestoreContext should always be prefixed with the check "restoreRequested". Your question should be handled above..
EWS
Comment 7 2022-03-23 10:13:22 PDT
Committed r291749 (248781@main): <https://commits.webkit.org/248781@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455373 [details].
Note You need to log in before you can comment on or make changes to this bug.