Bug 238902

Summary: [:has() pseudo-class] Support invalidation for :in-range/:out-of-range
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, koivisto, mifenton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 234556, 240762    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Tim Nguyen (:ntim)
Reported 2022-04-06 15:29:20 PDT
:in-range/:out-of-range should be a matter of using Style::PseudoClassChangeInvalidation instead of invalidateStyleForSubtree() where appropriate.
Attachments
Patch (3.29 KB, patch)
2022-05-20 03:35 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (5.08 KB, patch)
2022-05-20 04:52 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (5.26 KB, patch)
2022-05-21 01:21 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (5.11 KB, patch)
2022-05-21 02:41 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-04-13 15:30:13 PDT
<rdar://problem/91718746>
Antti Koivisto
Comment 2 2022-05-20 03:35:08 PDT
Created attachment 459612 [details] Patch
Antti Koivisto
Comment 3 2022-05-20 04:52:51 PDT
Created attachment 459613 [details] Patch
Tim Nguyen (:ntim)
Comment 4 2022-05-20 09:57:38 PDT
Comment on attachment 459613 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459613&action=review > LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has-expected.txt:10 > +PASS :out-of-range invalidation There are cases this doesn't cover fwiw: - type attribute change - min/max attribute change Might be worth extending the test, and adding support if necessary
Antti Koivisto
Comment 5 2022-05-21 01:21:21 PDT
Created attachment 459637 [details] Patch
Antti Koivisto
Comment 6 2022-05-21 01:22:16 PDT
> There are cases this doesn't cover fwiw: > - type attribute change > - min/max attribute change > > Might be worth extending the test, and adding support if necessary Good future tasks.
Antti Koivisto
Comment 7 2022-05-21 02:41:11 PDT
Created attachment 459638 [details] Patch
EWS
Comment 8 2022-05-21 08:15:15 PDT
Committed r294613 (250839@main): <https://commits.webkit.org/250839@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459638 [details].
Note You need to log in before you can comment on or make changes to this bug.