Bug 248015

Summary: [LFC][IFC] Introduce a fast path for finding breaking position when text content uses fixed pitch font
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 247782    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
[fast-cq] Patch none

alan
Reported 2022-11-16 19:45:59 PST
see webkit.org/b/221581
Attachments
Patch (3.73 KB, patch)
2022-11-16 19:56 PST, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (4.28 KB, patch)
2022-11-17 08:24 PST, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (4.27 KB, patch)
2022-11-17 08:44 PST, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch (4.31 KB, patch)
2022-12-08 09:11 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-11-16 19:56:22 PST
Created attachment 463569 [details] Patch
alan
Comment 2 2022-11-16 21:22:31 PST
need to look into imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-001.html
alan
Comment 3 2022-11-17 08:24:44 PST
Created attachment 463582 [details] Patch
alan
Comment 4 2022-11-17 08:44:21 PST
Created attachment 463583 [details] Patch
Radar WebKit Bug Importer
Comment 5 2022-11-23 19:46:16 PST
<rdar://problem/102637833>
Simon Fraser (smfr)
Comment 6 2022-11-28 11:13:33 PST
Comment on attachment 463583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463583&action=review > Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:246 > + size_t estimatedCharacterCount = availableWidth / monospaceCharacterWidth; An explicit floor() would make this slightly more self-explanatory
alan
Comment 7 2022-12-08 09:11:50 PST
Created attachment 463940 [details] [fast-cq] Patch
EWS
Comment 8 2022-12-08 13:15:49 PST
Committed 257585@main (97774366800c): <https://commits.webkit.org/257585@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463940 [details].
Note You need to log in before you can comment on or make changes to this bug.