Bug 264142
| Summary: | Move duplicated methods from MediaSourcePrivate/SourceBufferPrivate to base class | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 264134 | ||
Jean-Yves Avenard [:jya]
sub-task of bug 264134
We have three MSE implementations in our tree:
- Cocoa/AVFObjC
- Mock
- GStreamer
In a lot of instances, all three duplicates the same code. It makes it harder to maintain and too easy to introduce discrepancy between the three implementations.
Let's move to their respective base classes what can be moved.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/117892834>
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/19937
EWS
Committed 270354@main (e25a76a60507): <https://commits.webkit.org/270354@main>
Reviewed commits have been landed. Closing PR #19937 and removing active labels.