Bug 27588

Summary: Make most DOMObjects hold onto a JSDOMGlobalObject*
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 27622    
Bug Blocks: 27088, 27634    
Attachments:
Description Flags
patch
none
Just the code changes abarth: review+

Eric Seidel (no email)
Reported 2009-07-22 17:50:27 PDT
Make most DOMObjects hold onto a JSDOMGlobalObject* The only exceptions are the SVG objects.
Attachments
patch (54.86 KB, patch)
2009-07-22 18:24 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Just the code changes (26.92 KB, patch)
2009-07-23 13:43 PDT, Eric Seidel (no email) 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-07-22 18:24:57 PDT
Created attachment 33309 [details] patch
Eric Seidel (no email)
Comment 2 2009-07-23 11:11:24 PDT
I think Sam already got email about this through the bug relationships. But just in case, I'll CC him. This is a rather large change (although very little functional change) and I want to make sure folks have plenty of time to digest it. :)
Adam Barth
Comment 3 2009-07-23 11:16:48 PDT
Can we avoid the const_casts? Those are super ugly.
Eric Seidel (no email)
Comment 4 2009-07-23 11:42:25 PDT
I mentioned to Adam over chat: The large test I added has *no* functional changes from before and after this patch. It was written to catch anything that might have changed by this patch, but in the end, there was only one functional change from this patch, which i already covered by the existing tests. I could/should separate out the large test out of this patch and land it first. :)
Eric Seidel (no email)
Comment 5 2009-07-23 13:31:25 PDT
I've now broken the new test out into its own bug, bug 27622. I'll post a new patch shortly.
Eric Seidel (no email)
Comment 6 2009-07-23 13:43:39 PDT
Created attachment 33366 [details] Just the code changes --- 17 files changed, 147 insertions(+), 43 deletions(-)
Adam Barth
Comment 7 2009-07-23 23:32:29 PDT
Comment on attachment 33366 [details] Just the code changes After some clarifying questions via chat, I believe this patch is correct.
Eric Seidel (no email)
Comment 8 2009-07-23 23:58:16 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/fast/dom/prototype-inheritance-2-expected.txt M LayoutTests/fast/dom/prototype-inheritance-expected.txt M WebCore/ChangeLog M WebCore/bindings/js/DOMObjectWithSVGContext.h M WebCore/bindings/js/JSDOMBinding.h M WebCore/bindings/js/JSDOMGlobalObject.h M WebCore/bindings/js/JSDOMWindowCustom.cpp M WebCore/bindings/js/JSDocumentCustom.cpp M WebCore/bindings/js/JSHTMLAllCollection.h M WebCore/bindings/js/JSHTMLCollectionCustom.cpp M WebCore/bindings/js/JSHTMLFormElementCustom.cpp M WebCore/bindings/js/JSNamedNodesCollection.cpp M WebCore/bindings/js/JSNamedNodesCollection.h M WebCore/bindings/js/JSSharedWorkerConstructor.cpp M WebCore/bindings/js/JSSharedWorkerConstructor.h M WebCore/bindings/scripts/CodeGeneratorJS.pm Committed r46320 M WebCore/ChangeLog M WebCore/bindings/scripts/CodeGeneratorJS.pm M WebCore/bindings/js/JSSharedWorkerConstructor.h M WebCore/bindings/js/DOMObjectWithSVGContext.h M WebCore/bindings/js/JSSharedWorkerConstructor.cpp M WebCore/bindings/js/JSHTMLCollectionCustom.cpp M WebCore/bindings/js/JSDOMGlobalObject.h M WebCore/bindings/js/JSNamedNodesCollection.cpp M WebCore/bindings/js/JSHTMLFormElementCustom.cpp M WebCore/bindings/js/JSDOMBinding.h M WebCore/bindings/js/JSNamedNodesCollection.h M WebCore/bindings/js/JSDOMWindowCustom.cpp M WebCore/bindings/js/JSHTMLAllCollection.h M WebCore/bindings/js/JSDocumentCustom.cpp M LayoutTests/ChangeLog M LayoutTests/fast/dom/prototype-inheritance-2-expected.txt M LayoutTests/fast/dom/prototype-inheritance-expected.txt r46320 = cc7b4c4103deafff9b1fc0069ad4e87549d98161 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46320
Note You need to log in before you can comment on or make changes to this bug.