Bug 292191
| Summary: | [scroll-animations] WPT test scroll-animations/view-timelines/fieldset-source.html is a failure | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> |
| Component: | Animations | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | graouts, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://github.com/web-platform-tests/wpt/pull/52242 | ||
Antoine Quint
The WPT test scroll-animations/view-timelines/fieldset-source.html is a failure. It mistakenly is marked as PASS macOS at the moment because the failure happen within a forEach() callback, but it fails there too, not just on iOS.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/150198507>
Antoine Quint
The issue appears that in the test we are using getBoundingClientRect() which accounts for padding and border, but the measurements we're taking in ViewTimeline::cacheCurrentTime() do not account for that, so we're off by 6 pixels (2 pixels of padding and 4 pixels of border).
Antoine Quint
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/52242
Antoine Quint
https://github.com/WebKit/WebKit/pull/44683
EWS
Committed 294259@main (8e43c7ee7af5): <https://commits.webkit.org/294259@main>
Reviewed commits have been landed. Closing PR #44683 and removing active labels.
Antoine Quint
*** Bug 284532 has been marked as a duplicate of this bug. ***