Bug 29317

Summary: PrettyPatch displays last two lines of a git-format-patch diff strangely
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, cmarcelo, commit-queue, dbates, ddkilzer, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: https://bugs.webkit.org/attachment.cgi?id=39615&action=prettypatch
Attachments:
Description Flags
patch none

Eric Seidel (no email)
Reported 2009-09-16 15:37:36 PDT
PrettyPatch displays diff strangely https://bugs.webkit.org/attachment.cgi?id=39615&action=prettypatch Notice how there are no minus lines in the ChangeLog here: https://bugs.webkit.org/attachment.cgi?id=39615 Maybe he edited the diff by hand?
Attachments
patch (3.32 KB, patch)
2011-03-08 11:52 PST, Caio Marcelo de Oliveira Filho 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-09-16 15:39:28 PDT
Same trouble here: https://bugs.webkit.org/attachment.cgi?id=39658&action=prettypatch I think it might be related to git diffs.
Adam Roben (:aroben)
Comment 2 2009-09-16 16:06:32 PDT
That's just how the last two lines of git-format-patch files always appear with PrettyPatch. The last two lines look like this: -- 1.6.0.4 This is certainly a bug in PrettyPatch.
Caio Marcelo de Oliveira Filho
Comment 3 2011-03-08 11:52:10 PST
Created attachment 85071 [details] patch
Caio Marcelo de Oliveira Filho
Comment 4 2011-03-10 12:27:26 PST
I think this will fix bug 19963 as well.
WebKit Commit Bot
Comment 5 2011-03-10 16:06:31 PST
Comment on attachment 85071 [details] patch Clearing flags on attachment: 85071 Committed r80782: <http://trac.webkit.org/changeset/80782>
WebKit Commit Bot
Comment 6 2011-03-10 16:06:34 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2011-03-10 17:33:39 PST
http://trac.webkit.org/changeset/80782 might have broken GTK Linux 32-bit Release
Caio Marcelo de Oliveira Filho
Comment 8 2011-03-10 20:17:32 PST
*** Bug 19963 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.