Bug 30157

Summary:

[Qt] Symbian SBSv2 .code segment is too big for linker

Product:

WebKit

Reporter:

Janne Koskinen <koshuin>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Blocker

CC:

commit-queue, eric

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

S60 Hardware

OS:

S60 3rd edition

Bug Depends on:

Bug Blocks:

27065

Attachments:

Description	Flags
proposed fix for webcore.pro	none
proposed fix for webcore.pro take 2	none

Janne Koskinen

Reported 2009-10-07 01:16:32 PDT

Symbian's new build toolchain SBSv2 (Symbian Build System version 2) creates more code than the old SBSv1. Toolchain has a fixed start address for .data segment that .code segment overlaps with in SBSv2 causing the link stage to fail when building qtwebkit.dll.

Attachments
proposed fix for webcore.pro (1.12 KB, patch) 2009-10-07 01:21 PDT, Janne Koskinen	no flags	Details Formatted Diff Diff
proposed fix for webcore.pro take 2 (1.08 KB, patch) 2009-10-07 02:29 PDT, Janne Koskinen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Janne Koskinen

Comment 1 2009-10-07 01:21:48 PDT

Created attachment 40771 [details] proposed fix for webcore.pro Patch increases the base address of .data segment by passing linkeroption to RVCT's armlink.

Janne Koskinen

Comment 2 2009-10-07 02:29:26 PDT

Created attachment 40776 [details] proposed fix for webcore.pro take 2 removed the test cases missing part from changelog.

WebKit Commit Bot

Comment 3 2009-10-07 03:04:57 PDT

Comment on attachment 40776 [details] proposed fix for webcore.pro take 2 Rejecting patch 40776 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11400 test cases. storage/close-during-stress-test.html -> crashed Exiting early after 1 failures. 9384 tests run. 481.84s total testing time 9383 test cases (99%) succeeded 1 test case (<1%) crashed 6 test cases (<1%) had stderr output

Simon Hausmann

Comment 4 2009-10-07 03:48:18 PDT

Comment on attachment 40776 [details] proposed fix for webcore.pro take 2 Overriding the bot here, this patch cannot possibly have affected the failing test :)

WebKit Commit Bot

Comment 5 2009-10-07 03:58:23 PDT

Comment on attachment 40776 [details] proposed fix for webcore.pro take 2 Clearing flags on attachment: 40776 Committed r49239: <http://trac.webkit.org/changeset/49239>

WebKit Commit Bot

Comment 6 2009-10-07 03:58:26 PDT

All reviewed patches have been landed. Closing bug.

Eric Seidel (no email)

Comment 7 2009-10-07 09:39:21 PDT

(In reply to comment #4) > (From update of attachment 40776 [details]) > Overriding the bot here, this patch cannot possibly have affected the failing > test :) Agreed. Although when that happens we need to be sure to file bugs about the flakey tests. :) (Which is my job, don't get me wrong. But if somehow I don't notice a flakey test like this in the future, feel free/encouraged to ping me about it or CC me on the bug.) Filed bug 30172.

Note You need to log in before you can comment on or make changes to this bug.