Bug 30669

Summary: http/tests/xmlhttprequest/cross-origin-no-authorization.html has missing "DONE" in one branch
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: ap, eric, levin
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch - add "DONE" message when loading ended without an exception levin: review-, levin: commit-queue-

Roland Steiner
Reported 2009-10-22 02:41:45 PDT
The layout test http/tests/xmlhttprequest/cross-origin-no-authorization.html outputs "DONE" when it has finished running through the whole test. However, currently this is only done if the last test ends with a (caught) error, but not when loading ends regularly.
Attachments
patch - add "DONE" message when loading ended without an exception (1.38 KB, patch)
2009-10-22 02:46 PDT, Roland Steiner 		levin: review-
levin: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2009-10-22 02:46:41 PDT
Created attachment 41650 [details] patch - add "DONE" message when loading ended without an exception This patch adds a "DONE" message when loading ended without an exception (hopefully with a 401 result in that case).
Eric Seidel (no email)
Comment 2 2009-10-22 10:42:53 PDT
Comment on attachment 41650 [details] patch - add "DONE" message when loading ended without an exception What results does this affect? Why is this needed?
Alexey Proskuryakov
Comment 3 2009-10-22 17:13:30 PDT
Comment on attachment 41650 [details] patch - add "DONE" message when loading ended without an exception Seems harmless - the test was originally written to allow either outcome, so it should print DONE in both cases. It would be useful to document how you noticed this - did some browser engine you tested have a different behavior? Should we consider changing WebKit behavior?
David Levin
Comment 4 2009-10-22 17:21:03 PDT
Comment on attachment 41650 [details] patch - add "DONE" message when loading ended without an exception Roland, I'm pretty sure this is the wrong fix for chromium. Please talk to me for more details.
WebKit Commit Bot
Comment 5 2009-10-22 17:21:16 PDT
Comment on attachment 41650 [details] patch - add "DONE" message when loading ended without an exception Rejecting patch 41650 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11484 test cases. fast/media/mq-transform-02.html -> failed Exiting early after 1 failures. 7441 tests run. 143.22s total testing time 7440 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output
Eric Seidel (no email)
Comment 6 2009-10-23 12:05:42 PDT
Sorry about the commit-queue trouble. Should work fine now.
Alexey Proskuryakov
Comment 7 2010-07-20 12:50:49 PDT
Fixed with bug 41531 in <http://trac.webkit.org/changeset/63766>. > Roland, I'm pretty sure this is the wrong fix for chromium. Please talk to me for more details. This discussion hasn't been captured in Bugzilla, let's fix whatever problems arise if/when they do.
Note You need to log in before you can comment on or make changes to this bug.