Bug 32042
| Summary: | style-queue (or something) should r- patches missing ChangeLogs | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, levin, webkit.review.bot |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Eric Seidel (no email)
style-queue (or something) should r- patches missing ChangeLogs
Or at least make a nasty comment in the bug. Rarely can one actually review a patch w/o a ChangeLog.
We have at least one other bug about our tools warning us sooner, but if style-queue is the earliest we can get a warning, then so be it. It's better than the current pre-commit hook or reviewers spending time on it.
The bot should point people to http://webkit.org/coding/contributing.html or possibly http://webkit.org/coding/contributing.html#changelogs
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
A helpful comment would be OK, but you'd need to nominate the tool for reviewer status to actually r-.
And there are cases when it makes more sense to just manually adapt and land a one time contributor's patch than to educate them about our process. Sometimes people do useful things without long-term involvement with the project.
Alexey Proskuryakov
*** Bug 61458 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
*** Bug 62021 has been marked as a duplicate of this bug. ***