Bug 32224

Summary: Turn on (SVG) Filters support, by default.
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, krit, mjs, rwlbuis, staikos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 68469, 26389    
Attachments:
Description Flags
Patch, excluding LayoutTests changes
none
Build patches for win none

Nikolas Zimmermann
Reported 2009-12-07 08:59:31 PST
Enable (SVG) Filters support by default. The plan is to enable build on Mac only. The other platforms Skipped list will be adapted, to not run any test affected by the filter feature. If mac port builds fine, and the build bots are green again, the other platforms should be enabled one after another. Uploading a patch soon.
Attachments
Patch, excluding LayoutTests changes (159.94 KB, patch)
2009-12-07 09:36 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Build patches for win (25.20 KB, patch)
2009-12-08 08:10 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2009-12-07 09:36:40 PST
Created attachment 44418 [details] Patch, excluding LayoutTests changes Follow-up patch, will contain the LayoutTest results (big list of changes, all filter affected tests have to be rebaselined).
WebKit Review Bot
Comment 2 2009-12-07 09:41:09 PST
style-queue ran check-webkit-style on attachment 44418 [details] without any errors.
Holger Freyther
Comment 3 2009-12-07 09:58:13 PST
Comment on attachment 44418 [details] Patch, excluding LayoutTests changes > + Turn on (SVG) Filters support, by default. > + https://bugs.webkit.org/show_bug.cgi?id=32224 rs=me from the impressions I got from the webkit-dev thread. According to Niko we do have enough auto tests for SVG filters.
Nikolas Zimmermann
Comment 4 2009-12-07 15:04:55 PST
Landed patch enabling mac build in r51800. Waiting for bot results before proceeding.
Nikolas Zimmermann
Comment 5 2009-12-07 15:44:01 PST
Comment on attachment 44418 [details] Patch, excluding LayoutTests changes Clearing review flag, this patch has been landed.
Nikolas Zimmermann
Comment 6 2009-12-08 03:01:53 PST
All mac build slaves work fine, w/o regression since turning on filters. Qt has filters turned out, w/o layout test failures since r51841. Now gtk...
Nikolas Zimmermann
Comment 7 2009-12-08 03:02:12 PST
(In reply to comment #6) > All mac build slaves work fine, w/o regression since turning on filters. > Qt has filters turned out, w/o layout test failures since r51841. > Now gtk... s/turned out/turned on/
Nikolas Zimmermann
Comment 8 2009-12-08 06:39:59 PST
Gtk + Filters work properly after r51847 (bots green).
Nikolas Zimmermann
Comment 9 2009-12-08 08:10:44 PST
Created attachment 44473 [details] Build patches for win Adding the win patches, so I can show them around before landing. Already got a blind rs=mjs, given that I'm willing to watch builds and fix :-)
Dirk Schulze
Comment 10 2010-01-01 06:56:00 PST
(In reply to comment #9) > Created an attachment (id=44473) [details] > Build patches for win > > Adding the win patches, so I can show them around before landing. Already got a > blind rs=mjs, given that I'm willing to watch builds and fix :-) Filter are activated on every port. Can we close this bug now?
Nikolas Zimmermann
Comment 11 2010-01-02 07:01:19 PST
Agreed. Closing.
Note You need to log in before you can comment on or make changes to this bug.