Bug 33290

Summary: Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, webkit.review.bot, yaar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 33296    
Attachments:
Description Flags
Patch
none
Fix the english in my comment. abarth: review+, abarth: commit-queue+

Eric Seidel (no email)
Reported 2010-01-06 20:16:15 PST
Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red) http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/buildbot.py#L47 The Chromium bots seem to be pretty stable, so I think it's time that we can depend on them being green. The "core builders" is the subset of builder which cause the "tree to close" (even though WebKit never really closes the tree like Chromium does). I'll post a patch to fix this tomorrow unless I hear objections.
Attachments
Patch (4.44 KB, patch)
2010-01-07 00:06 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Fix the english in my comment. (4.46 KB, patch)
2010-01-07 00:10 PST, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-01-07 00:06:22 PST
Created attachment 46026 [details] Patch
WebKit Review Bot
Comment 2 2010-01-07 00:08:09 PST
style-queue ran check-webkit-style on attachment 46026 [details] without any errors.
Eric Seidel (no email)
Comment 3 2010-01-07 00:10:59 PST
Created attachment 46027 [details] Fix the english in my comment.
WebKit Review Bot
Comment 4 2010-01-07 00:13:29 PST
style-queue ran check-webkit-style on attachment 46027 [details] without any errors.
Eric Seidel (no email)
Comment 5 2010-01-07 00:57:34 PST
Committed r52908: <http://trac.webkit.org/changeset/52908>
Note You need to log in before you can comment on or make changes to this bug.