Bug 33369

Summary: Implement HTML5 <hgroup> element.
Product: WebKit Reporter: Kent Tamura <tkent>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, gustavo, mjs, webkit.review.bot
Priority: P2 Keywords: HTML5
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
URL: http://www.w3.org/TR/html5/semantics.html#the-hgroup-element
Bug Depends on:    
Bug Blocks: 32934    
Attachments:
Description Flags
Proposed patch
none
Proposed patch (rev.2) abarth: review+

Kent Tamura
Reported 2010-01-08 01:48:34 PST
Implement HTML5 <hgroup> element.
Attachments
Proposed patch (8.55 KB, patch)
2010-01-08 01:55 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Proposed patch (rev.2) (8.53 KB, patch)
2010-01-26 18:01 PST, Kent Tamura 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2010-01-08 01:55:39 PST
Created attachment 46119 [details] Proposed patch
WebKit Review Bot
Comment 2 2010-01-08 01:58:51 PST
style-queue ran check-webkit-style on attachment 46119 [details] without any errors.
Eric Seidel (no email)
Comment 3 2010-01-26 14:36:55 PST
Comment on attachment 46119 [details] Proposed patch The ChangeLog talks about <aside>?
Kent Tamura
Comment 4 2010-01-26 17:22:31 PST
(In reply to comment #3) > The ChangeLog talks about <aside>? Oh, silly copy&paste mistake. I'll update the patch...
Kent Tamura
Comment 5 2010-01-26 18:01:49 PST
Created attachment 47477 [details] Proposed patch (rev.2)
Eric Seidel (no email)
Comment 6 2010-02-01 15:27:39 PST
Every time I see this change in the review queue I skip over it becase I don't know what this is for or why we'd want it. I guess I just need to read the html5 spec.
Eric Seidel (no email)
Comment 7 2010-03-05 13:46:06 PST
Could you explain in the bug what <hgroup> is and why we would want it?
Kent Tamura
Comment 8 2010-03-07 16:50:50 PST
(In reply to comment #7) > Could you explain in the bug what <hgroup> is and why we would want it? Because it is defined in HTML5. http://www.w3.org/TR/html5/semantics.html#the-hgroup-element Though I feel the benefit of <hgroup>is less than other sectioning elements such as <section> <article> we already have, the example in the specification is reasonable and <hgroup> is not harmful.
Adam Barth
Comment 9 2010-03-08 10:55:26 PST
Comment on attachment 47477 [details] Proposed patch (rev.2) Sorry this took so long to review. HTML5++.
Kent Tamura
Comment 10 2010-03-08 22:27:47 PST
Landed as r55710.
Eric Seidel (no email)
Comment 11 2010-03-08 23:41:32 PST
It appears this checkin broke the Gtk bot: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r55710%20(589)/results.html (Or possibly the Gtk bot simply got itself wedged).
Gustavo Noronha (kov)
Comment 12 2010-03-11 11:25:06 PST
(In reply to comment #11) > It appears this checkin broke the Gtk bot: > http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r55710%20(589)/results.html > > (Or possibly the Gtk bot simply got itself wedged). Yes, looks like a temporary failure of the bot there, should be fixed now.
Note You need to log in before you can comment on or make changes to this bug.