Bug 37461

Summary: Spatial Navigation: make renderRectRelativeToRootDocument method to fallback to getRect() of Element when needed
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: AccessibilityAssignee: Antonio Gomes <tonikitoo>
Status: CLOSED FIXED    
Severity: Normal CC: hausmann, kenneth, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 18662    
Bug Blocks: 35784, 36463    
Attachments:
Description Flags
(committed in r57496) patch v1 none

Antonio Gomes
Reported 2010-04-12 12:13:54 PDT
As discussed in [1], renderer's absoluteClippedOverflowRect() method can return an empty IntRect when node() of renderer is offscreen. For this case, make spatial navigation to fallback to getRect of Element instead. [1] http://old.nabble.com/AbsoluteClippedOverflowRect-return-empty-IntRect-td28005341.html
Attachments
(committed in r57496) patch v1 (6.71 KB, patch)
2010-04-12 12:57 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2010-04-12 12:57:08 PDT
Created attachment 53182 [details] (committed in r57496) patch v1 fallback to getRect method Element when absoluteClippedOverflowRect of RenderObject returns a empty rect.
Antonio Gomes
Comment 2 2010-04-12 19:49:48 PDT
Comment on attachment 53182 [details] (committed in r57496) patch v1 (From update of attachment 53182 [details]) Clearing flags on attachment: 53182 Committed r57496: <http://trac.webkit.org/changeset/57496>
Antonio Gomes
Comment 3 2010-04-12 19:50:51 PDT
Thank you Simon Fraser!!!
Simon Hausmann
Comment 4 2010-04-20 13:21:29 PDT
Revision r57496 cherry-picked into qtwebkit-2.0 with commit 7d5c02b80c68d5cebe067bd0968b7dc9b6a12e92
Note You need to log in before you can comment on or make changes to this bug.