Bug 38125

Summary: View modes names in CSSValueKeywords.in
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: commit-queue, hausmann, laszlo.gombos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
patch 1
none
patch 2 none

Luiz Agostini
Reported 2010-04-26 07:15:07 PDT
View mode names has changed in previous patch but CSSValueKeywords.in file was not updated. Layout tests should fail but they do not because of bug 38116.
Attachments
patch 1 (1.47 KB, patch)
2010-04-26 07:21 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
patch 2 (1.47 KB, patch)
2010-04-26 07:38 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2010-04-26 07:21:24 PDT
Created attachment 54294 [details] patch 1
Laszlo Gombos
Comment 2 2010-04-26 07:22:57 PDT
Looks good, but should we sort these strings when possible ?
Luiz Agostini
Comment 3 2010-04-26 07:32:34 PDT
(In reply to comment #2) > Looks good, but should we sort these strings when possible ? no problem. :)
Luiz Agostini
Comment 4 2010-04-26 07:38:30 PDT
Created attachment 54299 [details] patch 2
WebKit Commit Bot
Comment 5 2010-04-26 09:21:52 PDT
Comment on attachment 54299 [details] patch 2 Clearing flags on attachment: 54299 Committed r58258: <http://trac.webkit.org/changeset/58258>
WebKit Commit Bot
Comment 6 2010-04-26 09:21:58 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 7 2010-05-05 08:14:03 PDT
Revision r58258 cherry-picked into qtwebkit-2.0 with commit ddf1a58c83038dfe71ff66417d4a4a8d0c3a2bb5
Note You need to log in before you can comment on or make changes to this bug.