Bug 38863

Summary: [Qt] Detect debug mode consistently
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: cshu, hausmann, koshuin, norbert.leser, ossy
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
use the CONFIG(release, debug|release) test everywhere none

Laszlo Gombos
Reported 2010-05-10 12:56:19 PDT
CONFIG(debug, debug|release) is not the same as !CONFIG(release, debug|release). This subtly difference only has impact in a few build environments. This difference has caused some hard to find build-breaks on Symbian. The proposal is to use only either CONFIG(release, debug|release) or CONFIG(debug, debug|release) conditions everywhere but do not mix them.
Attachments
use the CONFIG(release, debug|release) test everywhere (4.83 KB, patch)
2010-05-10 13:01 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2010-05-10 13:01:34 PDT
Created attachment 55595 [details] use the CONFIG(release, debug|release) test everywhere
Csaba Osztrogonác
Comment 2 2010-05-12 13:59:04 PDT
Landed: http://trac.webkit.org/changeset/59264
Simon Hausmann
Comment 3 2010-05-14 01:42:52 PDT
<cherry-pick-for-backport: r59264>
Simon Hausmann
Comment 4 2010-05-14 01:48:01 PDT
Revision r59264 cherry-picked into qtwebkit-2.0 with commit 4ee9c252c187832cec8bf0b82e89e6016aec5388
Note You need to log in before you can comment on or make changes to this bug.