Bug 39153

Summary: Canvas's toDataURL() should be case insensitive wrt the mimeType argument
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, hausmann, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 39173    
Bug Blocks: 35784    
Attachments:
Description Flags
Proposed patch
none
Patch for landing
none
Updated patch with specialized GTK expectations none

Andreas Kling
Reported 2010-05-15 00:13:06 PDT
See HTML5 spec 4.8.11: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-canvas-todataurl "User agents must convert the provided type to ASCII lowercase before establishing if they support that type and before creating the data: URL."
Attachments
Proposed patch (4.87 KB, patch)
2010-05-15 00:14 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.50 KB, patch)
2010-05-15 18:02 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Updated patch with specialized GTK expectations (5.92 KB, patch)
2010-05-16 00:41 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-05-15 00:14:57 PDT
Created attachment 56146 [details] Proposed patch
Kenneth Rohde Christiansen
Comment 2 2010-05-15 12:08:36 PDT
Comment on attachment 56146 [details] Proposed patch I would suggest linking to the spec in the ChangeLog, at least before landing.
Adam Barth
Comment 3 2010-05-15 18:02:35 PDT
Created attachment 56168 [details] Patch for landing
WebKit Commit Bot
Comment 4 2010-05-15 20:15:35 PDT
Comment on attachment 56168 [details] Patch for landing Clearing flags on attachment: 56168 Committed r59565: <http://trac.webkit.org/changeset/59565>
WebKit Commit Bot
Comment 5 2010-05-15 20:15:40 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-05-15 20:34:01 PDT
http://trac.webkit.org/changeset/59565 might have broken GTK Linux 32-bit Release
Eric Seidel (no email)
Comment 7 2010-05-15 21:36:12 PDT
This broke gtk. I can't roll it out from my phone, but someone should feel free to. :) it may just need espectations update. ;)
Adam Barth
Comment 9 2010-05-15 23:51:12 PDT
Rolling out.
Andreas Kling
Comment 10 2010-05-16 00:41:05 PDT
Created attachment 56181 [details] Updated patch with specialized GTK expectations Apparently GTK doesn't support the image/jpeg mimetype so the test outcome differs slightly.
WebKit Commit Bot
Comment 11 2010-05-16 14:09:03 PDT
Comment on attachment 56181 [details] Updated patch with specialized GTK expectations Clearing flags on attachment: 56181 Committed r59581: <http://trac.webkit.org/changeset/59581>
WebKit Commit Bot
Comment 12 2010-05-16 14:09:10 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 13 2010-05-18 22:02:53 PDT
Revision r59581 cherry-picked into qtwebkit-2.0 with commit ad27430eb1173d688a5a335edadb1c0d55462732
Note You need to log in before you can comment on or make changes to this bug.