Bug 39513

Summary:

[Qt] Using Accelerated Composing the rocket back animation on http://www.the-art-of-web.com/css/css-animation/ works differently as when not using AC.

Product:

WebKit

Reporter:

Kenneth Rohde Christiansen <kenneth>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Major

CC:

commit-queue, hausmann, laszlo.gombos, noam

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

Bug Blocks:

35784

Attachments:

Description	Flags
Patch	none
Same functionality, but also applied to opacity animations and without redundant conditionals :)	kenneth: review-
oops, some extra stuff got in there	kenneth: review+
second fix to the changelog	none

Kenneth Rohde Christiansen

Reported 2010-05-21 13:58:39 PDT

Created attachment 56743 [details] Patch When using the QWebGraphicsView which has AC enabled by default, the rocket back animation on http://www.the-art-of-web.com/css/css-animation/ works differently as when not using AC. It always goes back from the end position and not the current position.

Attachments
Patch (1.96 KB, patch) 2010-05-21 13:58 PDT, Kenneth Rohde Christiansen	no flags	Details Formatted Diff Diff
Same functionality, but also applied to opacity animations and without redundant conditionals :) (2.89 KB, patch) 2010-05-21 15:55 PDT, Noam Rosenthal	kenneth: review-	Details Formatted Diff Diff
oops, some extra stuff got in there (2.20 KB, patch) 2010-05-21 15:56 PDT, Noam Rosenthal	kenneth: review+	Details Formatted Diff Diff
second fix to the changelog (2.25 KB, patch) 2010-05-21 16:00 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Laszlo Gombos

Comment 1 2010-05-21 14:44:17 PDT

Noam, is there other places where m_fillsForward is not needed (e.g. for m_layer.data()->m_layer->setOpacity(opacity)) ?

Noam Rosenthal

Comment 2 2010-05-21 15:55:21 PDT

Created attachment 56758 [details] Same functionality, but also applied to opacity animations and without redundant conditionals :)

Noam Rosenthal

Comment 3 2010-05-21 15:56:29 PDT

Created attachment 56759 [details] oops, some extra stuff got in there

Kenneth Rohde Christiansen

Comment 4 2010-05-21 15:58:31 PDT

Comment on attachment 56758 [details] Same functionality, but also applied to opacity animations and without redundant conditionals :) WebCore/platform/network/qt/ResourceRequestQt.cpp:83 + #if 0 && QT_VERSION >= QT_VERSION_CHECK(4, 7, 0) This doesn't seem related!

Noam Rosenthal

Comment 5 2010-05-21 16:00:55 PDT

Created attachment 56760 [details] second fix to the changelog

WebKit Commit Bot

Comment 6 2010-05-23 04:59:26 PDT

Comment on attachment 56760 [details] second fix to the changelog Clearing flags on attachment: 56760 Committed r60040: <http://trac.webkit.org/changeset/60040>

Simon Hausmann

Comment 7 2010-05-25 14:29:12 PDT

Revision r60040 cherry-picked into qtwebkit-2.0 with commit b9c0ab3cefa31581779aee8deef391d19567006a

Note You need to log in before you can comment on or make changes to this bug.