Bug 39534

Summary: Add tests for previous HTML5 parser patches
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, mjs
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 39259    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2010-05-22 10:30:02 PDT
Add tests for previous HTML5 parser patches
Attachments
Patch (3.56 KB, patch)
2010-05-22 10:31 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-05-22 10:31:39 PDT
Created attachment 56782 [details] Patch
Eric Seidel (no email)
Comment 2 2010-05-22 10:39:15 PDT
Comment on attachment 56782 [details] Patch Seems the extra newlines around the script aren't necessary and just make the output more complicated. But otherwise looks fine.
Eric Seidel (no email)
Comment 3 2010-05-22 10:39:48 PDT
Also, I'm not sure <div><div> or the basic <script> are useful since this hardness has at least that. :)
Eric Seidel (no email)
Comment 4 2010-05-22 10:43:15 PDT
Up until now we've add to fix all of the bugs that you're testing here just to get this harness running. :) The harness is now useful because we can fix bugs in it.
Adam Barth
Comment 5 2010-05-22 10:53:02 PDT
Sure, but I don't think it's harmful to add these tests.
WebKit Commit Bot
Comment 6 2010-05-23 14:16:45 PDT
Comment on attachment 56782 [details] Patch Clearing flags on attachment: 56782 Committed r60049: <http://trac.webkit.org/changeset/60049>
WebKit Commit Bot
Comment 7 2010-05-23 14:16:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.