Bug 40065

Summary:

Geolocation callbacks should make use of new callback generation mechanism

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Steve Block <steveblock>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andreip, ap, buildbot, dbates, jknotten, leandrogracia, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

39879

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Steve Block

Reported 2010-06-02 08:24:53 PDT

Geolocation callbacks should make use of new callback generation mechanism. This will remove the need for the Geolocation custom callback code. See the equivalent change for Database in http://trac.webkit.org/changeset/58801

Attachments
Patch (55.27 KB, patch) 2011-04-13 03:57 PDT, Steve Block	no flags	Details Formatted Diff Diff
Patch (68.99 KB, patch) 2011-04-13 08:47 PDT, Steve Block	no flags	Details Formatted Diff Diff
Patch (52.04 KB, patch) 2011-05-23 15:36 PDT, Steve Block	no flags	Details Formatted Diff Diff
Patch (65.94 KB, patch) 2011-05-24 02:38 PDT, Steve Block	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Steve Block

Comment 1 2010-06-02 11:12:18 PDT

Bug 40071 is adding a weak pointer wrapper around ScriptExecutionContext. This is required for Bug 39879 which fixes a Geolocation crash. We should hold off on switching to the generated callbacks until this is complete and Geolocation tests are in place to check the behavior.

Steve Block

Comment 2 2011-03-24 03:55:46 PDT

The resolution of Bug 40071 was to not use a weak wrapper around ScriptExecutionContext, but instead to make callbacks inherit from ActiveDOMObject. The (hand written) Geolocation callbacks were updated to use this approach in http://trac.webkit.org/changeset/60840 http://trac.webkit.org/changeset/58801 updated the bindings script to automatically generate callbacks, and updated all DB callbacks to be automatically generated. The automatically generated callbacks were updated in http://trac.webkit.org/changeset/64537 to use ActiveDOMObject, similar to how the Geolocation callbacks do. So we should now be able to switch to the automatically generated callbacks for Geolocation. Note that there is ongoing discussion about a more fundamental refactoring of Geolocation - https://bugs.webkit.org/show_bug.cgi?id=40162 - but I think that eliminating custom bindings code still makes sense now.

Steve Block

Comment 3 2011-03-24 04:07:18 PDT

Adding Leandro as this will be relevant to Media Streaming. See Bug 56459.

Steve Block

Comment 4 2011-04-13 03:57:52 PDT

Created attachment 89361 [details] Patch

Daniel Bates

Comment 5 2011-04-13 04:30:58 PDT

Attachment 89361 [details] did not build on mac: Build output: http://queues.webkit.org/results/8404205

Build Bot

Comment 6 2011-04-13 05:20:30 PDT

Attachment 89361 [details] did not build on win: Build output: http://queues.webkit.org/results/8401286