Bug 40497

Summary: do-webcore-rename should have a --verbose option
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, commit-queue, darin, dbates
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 40491    
Attachments:
Description Flags
Patch
none
Fixed --help support per wms's comment none

Eric Seidel (no email)
Reported 2010-06-11 14:06:03 PDT
do-webcore-rename should have a --verbose option
Attachments
Patch (3.28 KB, patch)
2010-06-11 14:09 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Fixed --help support per wms's comment (3.37 KB, patch)
2010-06-11 14:36 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-06-11 14:09:39 PDT
Created attachment 58506 [details] Patch
Eric Seidel (no email)
Comment 2 2010-06-11 14:36:37 PDT
Created attachment 58509 [details] Fixed --help support per wms's comment
Eric Seidel (no email)
Comment 3 2010-06-11 14:36:58 PDT
Comment on attachment 58509 [details] Fixed --help support per wms's comment I keep forgetting to pass --request-commit. sigh.
Daniel Bates
Comment 4 2010-06-12 10:22:26 PDT
Comment on attachment 58509 [details] Fixed --help support per wms's comment > - if ($file =~ /^\../) { > + # Ignore excluded and hidden files/directories. > + if ($directoriesToIgnore{$file} or $file =~ /^\../ or $file =~ /^ChangeLog/) { > + print "Ignoring $File::Find::name\n" if $verbose; > $File::Find::prune = 1; As far as I can tell, $File::Find::prune only makes sense with respects to directories (to prevent descending into a directory), but I don't anticipate any issues with setting this on a file, say the ChangeLog files. > return; r=me.
Eric Seidel (no email)
Comment 5 2010-06-12 20:34:20 PDT
Comment on attachment 58509 [details] Fixed --help support per wms's comment Yup the "extra" prune causes no harm.
WebKit Commit Bot
Comment 6 2010-06-12 22:19:47 PDT
Comment on attachment 58509 [details] Fixed --help support per wms's comment Clearing flags on attachment: 58509 Committed r61080: <http://trac.webkit.org/changeset/61080>
WebKit Commit Bot
Comment 7 2010-06-12 22:19:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.