Bug 40513

Summary:

Rename tok, asHTMLTokenizer to parser, asHTMLDocumentParser

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

40491

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none

Eric Seidel (no email)

Reported 2010-06-11 18:49:53 PDT

Rename tok, asHTMLTokenizer to parser, asHTMLDocumentParser

Attachments
Patch (5.15 KB, patch) 2010-06-11 18:52 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch for landing (5.13 KB, patch) 2010-06-13 17:26 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch for landing (5.14 KB, patch) 2010-06-13 17:31 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-06-11 18:52:08 PDT

Created attachment 58538 [details] Patch

WebKit Commit Bot

Comment 2 2010-06-12 10:39:32 PDT

Comment on attachment 58538 [details] Patch Rejecting patch 58538 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Last 500 characters of output: o this was: -------------------------- |Index: WebCore/html/HTMLDocumentParser.h |index 9ccebe5dc17668f3082dee5bb7ebfd9f391d216c..0951c2a358d0d81416792931e1601a2941b2af1c 100644 |--- WebCore/html/HTMLDocumentParser.h |+++ WebCore/html/HTMLDocumentParser.h -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored patching file WebCore/loader/DocumentLoader.cpp Hunk #1 FAILED at 393. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/loader/DocumentLoader.cpp.rej Full output: http://webkit-commit-queue.appspot.com/results/3183377

WebKit Commit Bot

Comment 3 2010-06-13 00:26:50 PDT

Comment on attachment 58538 [details] Patch Rejecting patch 58538 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Last 500 characters of output: unk #1 succeeded at 1 with fuzz 3. patching file WebCore/dom/Document.cpp Hunk #1 FAILED at 1958. Hunk #2 FAILED at 1966. 2 out of 2 hunks FAILED -- saving rejects to file WebCore/dom/Document.cpp.rej patching file WebCore/dom/DocumentParser.h patching file WebCore/html/HTMLDocumentParser.cpp patching file WebCore/html/HTMLDocumentParser.h patching file WebCore/loader/DocumentLoader.cpp Hunk #1 FAILED at 393. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/loader/DocumentLoader.cpp.rej Full output: http://webkit-commit-queue.appspot.com/results/3273026

Eric Seidel (no email)

Comment 4 2010-06-13 17:25:27 PDT

Comment on attachment 58538 [details] Patch One more try now that I've updated bug 40512.

Eric Seidel (no email)

Comment 5 2010-06-13 17:26:55 PDT

Created attachment 58606 [details] Patch for landing

Eric Seidel (no email)

Comment 6 2010-06-13 17:31:29 PDT

Created attachment 58607 [details] Patch for landing

Adam Barth

Comment 7 2010-06-13 21:44:39 PDT

Comment on attachment 58607 [details] Patch for landing Clearing flags on attachment: 58607 Committed r61105: <http://trac.webkit.org/changeset/61105>

Adam Barth

Comment 8 2010-06-13 21:44:46 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.