Bug 41144

Summary: Implement the HTML5 <mark> element.
Product: WebKit Reporter: Peter Beverloo <peter>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mike
Priority: P2 Keywords: HTML5
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 32934    
Attachments:
Description Flags
Proposed patch
mjs: review-
Patch + Regression tests none

Peter Beverloo
Reported 2010-06-24 04:00:15 PDT
Created attachment 59629 [details] Proposed patch This patch adds support for the HTML5 <mark> element to WebKit. The default style has been based on the current behavior of searching in Chrome, as well as on Mozilla's implementation of the tag[1]. I'm not sure about how to add tests for this, if they are required, advice would be appreciated.
Attachments
Proposed patch (4.00 KB, patch)
2010-06-24 04:00 PDT, Peter Beverloo 		mjs: review-
DetailsFormatted DiffDiff
Patch + Regression tests (7.46 KB, patch)
2010-07-02 00:14 PDT, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2010-07-01 13:28:16 PDT
Comment on attachment 59629 [details] Proposed patch Code change looks great! The one thing missing here is a regression test. Take a look at LayoutTests/fast/html for some tests for revently added HTML5 elements. r- for the lack of test, please resubmit with a test case.
Peter Beverloo
Comment 2 2010-07-02 00:14:43 PDT
Created attachment 60343 [details] Patch + Regression tests Added a regression test for the element.
Maciej Stachowiak
Comment 3 2010-07-02 12:13:34 PDT
Comment on attachment 60343 [details] Patch + Regression tests r=me
WebKit Commit Bot
Comment 4 2010-07-02 12:45:40 PDT
Comment on attachment 60343 [details] Patch + Regression tests Clearing flags on attachment: 60343 Committed r62398: <http://trac.webkit.org/changeset/62398>
WebKit Commit Bot
Comment 5 2010-07-02 12:45:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.