Bug 41239

Summary: We should parse <html>
Product: WebKit Reporter: Adam Barth <abarth>
Component: DOMAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2010-06-25 17:30:35 PDT
We should parse <html>
Attachments
Patch (5.97 KB, patch)
2010-06-25 17:34 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-06-25 17:34:28 PDT
Created attachment 59816 [details] Patch
Eric Seidel (no email)
Comment 2 2010-06-25 17:39:35 PDT
Comment on attachment 59816 [details] Patch OK. rs=me.
Adam Barth
Comment 3 2010-06-25 17:48:09 PDT
Comment on attachment 59816 [details] Patch Clearing flags on attachment: 59816 Committed r61925: <http://trac.webkit.org/changeset/61925>
Adam Barth
Comment 4 2010-06-25 17:48:14 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2010-06-28 10:40:41 PDT
> This patch is hard to test Why is it hard to test? Won't an iframe pointing to such a document do it? Or is it that HTMLTreeBuilder is in a state where nothing works yet?
Adam Barth
Comment 6 2010-06-28 10:46:15 PDT
> Why is it hard to test? Won't an iframe pointing to such a document do it? You're presupposing that we could parse an <iframe> tag at this point. Literally, this patch let us parse the document "<html>" and nothing else. > Or is it that HTMLTreeBuilder is in a state where nothing works yet? We're rapidly approaching the point where we can parse HTML5lib's runner.html. At that point, adding tests will be easy.
Eric Seidel (no email)
Comment 7 2010-06-28 13:08:24 PDT
We actually cant' run the runner yet, but we're testing it it already: https://trac.webkit.org/changeset/61989 https://trac.webkit.org/changeset/61991
Note You need to log in before you can comment on or make changes to this bug.