Bug 42222

Summary: reconstructActiveFormElements should reconstruct attributes as well
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch abarth: review+, abarth: commit-queue-

Eric Seidel (no email)
Reported 2010-07-13 18:15:30 PDT
reconstructActiveFormElements should reconstruct attributes instead
Attachments
Patch (16.89 KB, patch)
2010-07-13 18:47 PDT, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-07-13 18:47:37 PDT
Created attachment 61453 [details] Patch
Adam Barth
Comment 2 2010-07-14 09:58:44 PDT
Comment on attachment 61453 [details] Patch LayoutTests/ChangeLog:5 + reconstructActiveFormElements should reconstruct attributes instead instead? LayoutTests/html5lib/resources/adoption01.dat:163 + | "document.getElementById("A").id = "B"" Nice test. Will this cause problems for us when we upstream these tests? We might want to separate tests that require scripts into their own dat file. WebCore/html/HTMLConstructionSite.cpp:303 + namespace { Please place this block at the top of the file. WebCore/html/HTMLConstructionSite.h:67 + // Used by the adoption agency. Please remove this comment.
Eric Seidel (no email)
Comment 3 2010-07-14 11:37:43 PDT
(In reply to comment #2) > (From update of attachment 61453 [details]) > LayoutTests/ChangeLog:5 > + reconstructActiveFormElements should reconstruct attributes instead > instead? Fixed. > LayoutTests/html5lib/resources/adoption01.dat:163 > + | "document.getElementById("A").id = "B"" > Nice test. Will this cause problems for us when we upstream these tests? We might want to separate tests that require scripts into their own dat file. I think we should do that when we understand the upstreaming requirements. > WebCore/html/HTMLConstructionSite.cpp:303 > + namespace { > Please place this block at the top of the file. Why? > WebCore/html/HTMLConstructionSite.h:67 > + // Used by the adoption agency. > Please remove this comment. OK. Fixed.
Eric Seidel (no email)
Comment 4 2010-07-14 11:50:30 PDT
Committed r63338: <http://trac.webkit.org/changeset/63338>
Note You need to log in before you can comment on or make changes to this bug.