Bug 42348

Summary: fast/events/focusingUnloadedFrame.html shouldn't have <body> before <frameset>
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Adam Barth
Reported 2010-07-15 02:45:25 PDT
fast/events/focusingUnloadedFrame.html shouldn't have <body> before <frameset>
Attachments
Patch (1.36 KB, patch)
2010-07-15 02:47 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.35 KB, patch)
2010-07-15 13:36 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.42 KB, patch)
2010-07-19 18:30 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-07-15 02:47:08 PDT
Created attachment 61625 [details] Patch
Darin Adler
Comment 2 2010-07-15 09:37:00 PDT
Comment on attachment 61625 [details] Patch > + This doesn't work in the HTML5 parser. We cover this behavior in > + parsing tests. Sadly, the test still failes under the HTML5 parser, > + but for a different reason. One space after period. Typo in the word "failes".
Adam Barth
Comment 3 2010-07-15 09:38:06 PDT
Comment on attachment 61625 [details] Patch Thanks.
Adam Barth
Comment 4 2010-07-15 13:36:02 PDT
Created attachment 61709 [details] Patch for landing
WebKit Commit Bot
Comment 5 2010-07-15 17:34:54 PDT
Comment on attachment 61709 [details] Patch for landing Rejecting patch 61709 from commit-queue. Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Last 500 characters of output: eLog M LayoutTests/fast/events/focusingUnloadedFrame.html A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: The following files contain tab characters: trunk/LayoutTests/fast/events/focusingUnloadedFrame.html Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/git/libexec/git-core/git-svn line 570 Full output: http://webkit-commit-queue.appspot.com/results/3420284
Adam Barth
Comment 6 2010-07-19 18:30:34 PDT
Created attachment 62022 [details] Patch for landing
WebKit Commit Bot
Comment 7 2010-07-20 01:31:28 PDT
Comment on attachment 62022 [details] Patch for landing Clearing flags on attachment: 62022 Committed r63733: <http://trac.webkit.org/changeset/63733>
WebKit Commit Bot
Comment 8 2010-07-20 01:31:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.