Bug 42376

Summary: svg/dynamic-updates tests are broken - pixel test not generated/compared anymore
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Critical CC: zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 42374    
Bug Blocks: 42615, 42616, 42617, 42618    
Attachments:
Description Flags
Patch mjs: review+

Nikolas Zimmermann
Reported 2010-07-15 07:55:41 PDT
Since a while, can't say how long, didn't investigate - DRT doesn't generate pixel test results for tests which have dumpAsText=true set. With the DRT change in bug 42374, I can reactivate them - and it's already visible that we have regressions *SIGH*. The svg/dynamic-updates tests want textual results (no render tree dumps) and a pixel test result - w/o pixel tests they're useless, as they are specifically testing dynamic changes of certain attributes/properties + repainting.
Attachments
Patch (deleted)
2010-07-20 00:34 PDT, Nikolas Zimmermann 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-07-20 00:34:00 PDT
Created attachment 62038 [details] Patch Large patch, as it contains the new pixel test baseline for svg/dynamic-updates.
Maciej Stachowiak
Comment 2 2010-07-20 00:43:20 PDT
Comment on attachment 62038 [details] Patch r=me
Nikolas Zimmermann
Comment 3 2010-07-20 00:48:19 PDT
Landed in r63730.
Note You need to log in before you can comment on or make changes to this bug.