Bug 49259

Summary: Rename GeolocationControllerClient to GeolocationClient
Product: WebKit Reporter: John Knottenbelt <jknotten>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, sam, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 49258    
Attachments:
Description Flags
Patch
none
Rename GeolocationControllerClient -> GeolocationClient
none
Patch
none
Patch none

John Knottenbelt
Reported 2010-11-09 09:59:00 PST
Rename WebCore::GeolocationControllerClient to WebCore::GeolocationClient to be more consistent with other Controller / Client pairs: - ContextMenuController / ContextMenuClient - DragController / DragClient - DeviceOrientationController / DeviceOrientationClient - DeviceMotionController / DeviceMotionClient
Attachments
Patch (24.74 KB, patch)
2010-11-10 01:54 PST, John Knottenbelt 		no flags
DetailsFormatted DiffDiff
Rename GeolocationControllerClient -> GeolocationClient (48.52 KB, patch)
2010-11-11 07:35 PST, John Knottenbelt 		no flags
DetailsFormatted DiffDiff
Patch (55.60 KB, patch)
2010-11-11 08:23 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch (55.61 KB, patch)
2010-11-12 03:14 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
John Knottenbelt
Comment 1 2010-11-10 01:54:16 PST
Created attachment 73474 [details] Patch
Steve Block
Comment 2 2010-11-11 04:11:43 PST
Let's get this resolved before we add the client mock in Bug 49258.
Steve Block
Comment 3 2010-11-11 04:19:35 PST
Comment on attachment 73474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73474&action=review Sounds good to me. InspectorController/InspectorClient also follows this pattern. The only other example I can see of the other style is BackForwardController/BackForwardControllerClient. This patch appears to be missing the change to GeolocationClient.h/cpp? Also, it looks like you might need to rebase for win before landing. > WebKit/mac/WebView/WebView.mm:710 > + pageClients.geolocationControllerClient = new WebGeolocationClient(self); Can you fix up PageClients to reflect the new name?
John Knottenbelt
Comment 4 2010-11-11 07:35:13 PST
Created attachment 73609 [details] Rename GeolocationControllerClient -> GeolocationClient Rename page clients as well.
Steve Block
Comment 5 2010-11-11 08:18:54 PST
Comment on attachment 73609 [details] Rename GeolocationControllerClient -> GeolocationClient Looks good but git has lost the SVN renaming history. I'll take the patch and fix it up with my SVN checkout.
Steve Block
Comment 6 2010-11-11 08:23:02 PST
Created attachment 73616 [details] Patch
John Knottenbelt
Comment 7 2010-11-11 08:31:11 PST
LGTM. Patch is the same as mine, but with proper svn rename tracking.
WebKit Commit Bot
Comment 8 2010-11-11 14:19:42 PST
The commit-queue encountered the following flaky tests while processing attachment 73616 [details]: http/tests/appcache/top-frame-3.html Please file bugs against the tests. These tests were authored by ap@webkit.org and dimich@chromium.org. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9 2010-11-11 14:22:56 PST
Comment on attachment 73616 [details] Patch Rejecting patch 73616 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 73616]" exit_code: 2 Last 500 characters of output: Kit/mac/WebView/WebView.mm M WebKit/win/ChangeLog M WebKit/win/WebKit.vcproj/WebKit.vcproj M WebKit/win/WebView.cpp A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebCore/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/git/libexec/git-core/git-svn line 558 Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Full output: http://queues.webkit.org/results/5698002
Steve Block
Comment 10 2010-11-12 03:14:04 PST
Created attachment 73726 [details] Patch
Steve Block
Comment 11 2010-11-12 03:14:35 PST
Comment on attachment 73726 [details] Patch Fixed 'OOPS'
WebKit Commit Bot
Comment 12 2010-11-12 04:02:16 PST
The commit-queue encountered the following flaky tests while processing attachment 73726 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by dumi@chromium.org. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 13 2010-11-12 04:04:47 PST
Comment on attachment 73726 [details] Patch Clearing flags on attachment: 73726 Committed r71903: <http://trac.webkit.org/changeset/71903>
WebKit Commit Bot
Comment 14 2010-11-12 04:04:53 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 15 2010-11-12 05:52:25 PST
http://trac.webkit.org/changeset/71903 might have broken GTK Linux 32-bit Release The following tests are not passing: http/tests/xmlhttprequest/xmlhttprequest-sync-vs-async-assertion-failure.html
Note You need to log in before you can comment on or make changes to this bug.