Bug 50920

Summary: Fix layout test dom/fast/Geolocation/permission-denied-already-error.html for client-based Geolocation
Product: WebKit Reporter: John Knottenbelt <jknotten>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 50562    
Attachments:
Description Flags
Patch none

John Knottenbelt
Reported 2010-12-13 06:17:53 PST
Use a valid error code (position unavailable == 2) to avoid an assertion failure in Chromium's client-based mock geolocation client.
Attachments
Patch (1.48 KB, patch)
2010-12-13 06:19 PST, John Knottenbelt 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Knottenbelt
Comment 1 2010-12-13 06:19:23 PST
Created attachment 76379 [details] Patch
Steve Block
Comment 2 2010-12-13 06:30:56 PST
Comment on attachment 76379 [details] Patch r=me
WebKit Commit Bot
Comment 3 2010-12-13 07:18:00 PST
The commit-queue encountered the following flaky tests while processing attachment 76379 [details]: fast/profiler/throw-exception-from-eval.html bug 50923 (authors: kmccullough@apple.com, oliver@apple.com, and timothy@apple.com) inspector/syntax-highlight-css.html bug 50924 (authors: keishi@webkit.org, pfeldman@chromium.org, and yurys@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2010-12-13 07:54:46 PST
Comment on attachment 76379 [details] Patch Clearing flags on attachment: 76379 Committed r73919: <http://trac.webkit.org/changeset/73919>
WebKit Commit Bot
Comment 5 2010-12-13 07:54:51 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-12-13 09:05:55 PST
http://trac.webkit.org/changeset/73919 might have broken GTK Linux 64-bit Debug
Note You need to log in before you can comment on or make changes to this bug.