Bug 54367

Summary: WebCore fails to build with Clang's -Woverloaded-virtual
Product: WebKit Reporter: Cameron Zwarich (cpst) <zwarich>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, sam, simon.fraser, thakis, zwarich
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 54301, 54305, 54909, 54914, 54920, 54922, 54923, 54924    
Bug Blocks:    
Attachments:
Description Flags
Patch for one case andersca: review+, zwarich: commit-queue-

Cameron Zwarich (cpst)
Reported 2011-02-13 15:43:55 PST
WebCore fails to build with Clang's -Woverloaded-virtual for a number of reasons. We should fix them all (besides wanting to build with Clang), as they are usually the sign of real bugs.
Attachments
Patch for one case (1.37 KB, patch)
2011-02-13 15:47 PST, Cameron Zwarich (cpst) 		andersca: review+
zwarich: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cameron Zwarich (cpst)
Comment 1 2011-02-13 15:47:41 PST
Created attachment 82280 [details] Patch for one case
Simon Fraser (smfr)
Comment 2 2011-02-13 16:01:22 PST
See bug 23120.
Cameron Zwarich (cpst)
Comment 3 2011-02-13 16:03:13 PST
Sorry for not finding the old bug. Unfortunately, this warning is enabled by default with Clang, whereas it is not enabled by default with GCC. ;-) Should we dupe them?
Cameron Zwarich (cpst)
Comment 4 2011-02-13 16:14:37 PST
Landed in r78447.
Nico Weber
Comment 5 2011-02-21 18:53:57 PST
The blocker list is (at the moment) a complete list of issues that prevents turning this on for the chromium port. All but one of the blockers have patches waiting for review.
Nico Weber
Comment 6 2011-02-21 19:05:17 PST
…and now they all have patches attached.
Nico Weber
Comment 7 2011-02-22 15:36:02 PST
The chromium port now builds fine with clang.
Nico Weber
Comment 8 2011-02-22 15:36:16 PST
(…with -Woverloaded-virtual, that is)
Note You need to log in before you can comment on or make changes to this bug.