Bug 55042

Summary: IndexedDB: Each layout test should use a separate DB
Product: WebKit Reporter: Hans Wennborg <hans>
Component: New BugsAssignee: Hans Wennborg <hans>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, commit-queue, dgrogan, jorlow
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Hans Wennborg
Reported 2011-02-23 06:08:00 PST
IndexedDB: Each layout test should use a separate DB
Attachments
Patch (49.44 KB, patch)
2011-02-23 06:10 PST, Hans Wennborg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hans Wennborg
Comment 1 2011-02-23 06:10:03 PST
Created attachment 83478 [details] Patch
Hans Wennborg
Comment 2 2011-02-23 06:13:53 PST
This morning saw some changes that made IndexedDB tests fail, seemingly because the tests got run in parallel. If we let each test use its own database, this shouldn't be a problem. (This was on my Linux box after http://trac.webkit.org/changeset/79424 landed, and it went away if I ran the tests with --worker-model=old-threads. It doesn't seem to affect the bots(?), but I think we should fix it anyway.) Please review.
Jeremy Orlow
Comment 3 2011-02-23 10:07:42 PST
Comment on attachment 83478 [details] Patch r=me feel free to land yourself, but cq just in case it beats you
Jeremy Orlow
Comment 4 2011-02-23 10:08:21 PST
David/Andrei: please follow this naming scheme from now on
WebKit Commit Bot
Comment 5 2011-02-23 10:33:18 PST
The commit-queue encountered the following flaky tests while processing attachment 83478 [details]: inspector/elements/insert-node-collapsed.html bug 55058 (author: pfeldman@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-02-23 10:35:11 PST
Comment on attachment 83478 [details] Patch Clearing flags on attachment: 83478 Committed r79458: <http://trac.webkit.org/changeset/79458>
WebKit Commit Bot
Comment 7 2011-02-23 10:35:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.