Bug 55139

Summary: [Qt] Remove bogus optimizations in TextBreakIteratorQt
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: christopher.reiss, hausmann, qt, stawel
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch kenneth: review+

Andreas Kling
Reported 2011-02-24 06:38:43 PST
TextBreakIteratorQt is currently quite broken, see bug 46695 for more details. While we wait for an ideal fix, let's remove the optimizations that are causing the crashiness.
Attachments
Proposed patch (2.76 KB, patch)
2011-02-24 06:40 PST, Andreas Kling 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-02-24 06:40:08 PST
Created attachment 83646 [details] Proposed patch
Simon Hausmann
Comment 2 2011-02-24 07:01:18 PST
For the record: Move the deep string copy until after the comparision fails, to avoid a deep copy when we hit the "cache" :)
Andreas Kling
Comment 3 2011-02-24 07:17:31 PST
(In reply to comment #2) > For the record: Move the deep string copy until after the comparision fails, to avoid a deep copy when we hit the "cache" :) I'm a stupidface. Of course. :)
Andreas Kling
Comment 4 2011-02-24 08:09:34 PST
Committed r79567: <http://trac.webkit.org/changeset/79567>
Andreas Kling
Comment 5 2011-02-25 06:22:43 PST
*** Bug 55215 has been marked as a duplicate of this bug. ***
Andreas Kling
Comment 6 2011-05-27 02:09:12 PDT
*** Bug 61619 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.