Bug 55205

Summary: HashSet<T>::end() creation is expensive and should be avoided
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aestes, commit-queue, darin, eric, mjs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 48719    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2011-02-24 23:20:45 PST
HashSet<T>::end() creation is expensive and should be avoided
Attachments
Patch (5.09 KB, patch)
2011-02-24 23:22 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-02-24 23:22:28 PST
Created attachment 83776 [details] Patch
Maciej Stachowiak
Comment 2 2011-02-24 23:28:58 PST
Comment on attachment 83776 [details] Patch r=me
WebKit Commit Bot
Comment 3 2011-02-26 05:46:23 PST
Comment on attachment 83776 [details] Patch Rejecting attachment 83776 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'bu..." exit_code: 2 Last 500 characters of output: .......................................................................................................... http/tests/ssl ... http/tests/storage . http/tests/uri .... http/tests/webarchive ..... http/tests/websocket/tests .......................... http/tests/websocket/tests/multiple-connections.html -> failed Exiting early after 1 failures. 22543 tests run. 703.11s total testing time 22542 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 14 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/8034759
WebKit Commit Bot
Comment 4 2011-02-26 05:47:29 PST
Comment on attachment 83776 [details] Patch Clearing flags on attachment: 83776 Committed r79780: <http://trac.webkit.org/changeset/79780>
WebKit Commit Bot
Comment 5 2011-02-26 05:47:35 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 6 2011-02-26 09:22:24 PST
Maybe we could special case HashTable::end since the hash table knows its empty and could just return begin in that case.
WebKit Review Bot
Comment 7 2011-02-27 09:01:22 PST
http://trac.webkit.org/changeset/79780 might have broken GTK Linux 64-bit Debug
Note You need to log in before you can comment on or make changes to this bug.