Bug 55774

Summary: Split JNIBridge.cpp/h into JavaString.h and JavaMethod.cpp/h
Product: WebKit Reporter: Steve Block <steveblock>
Component: New BugsAssignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: jorlow, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 55772    
Bug Blocks: 55765, 55879, 55881    
Attachments:
Description Flags
Patch 1 jorlow: review+

Steve Block
Reported 2011-03-04 08:08:41 PST
Split JNIBridge into JavaString.h and JavaM:qethod.cpp/h
Attachments
Patch 1 (35.43 KB, patch)
2011-03-07 07:53 PST, Steve Block 		jorlow: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2011-03-04 08:11:04 PST
JNIBridge.cpp/h contains only two classes - JavaMethod and JavaString - and it would aid clarity to split these into their own classes
Steve Block
Comment 2 2011-03-07 07:53:00 PST
Created attachment 84945 [details] Patch 1
Jeremy Orlow
Comment 3 2011-03-07 09:54:23 PST
Comment on attachment 84945 [details] Patch 1 style seems good. rubber stamp = me
Steve Block
Comment 4 2011-03-07 10:10:25 PST
Committed r80472: <http://trac.webkit.org/changeset/80472>
Note You need to log in before you can comment on or make changes to this bug.