Bug 55842

Summary: [Qt] Simplify how QWebFrame::requestedUrl() is obtained
Product: WebKit Reporter: Caio Marcelo de Oliveira Filho <cmarcelo>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, tonikitoo
Priority: P3 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch
none
patch with improved ChangeLog none

Caio Marcelo de Oliveira Filho
Reported 2011-03-06 06:49:17 PST
The idea here is to always store the requested url once frame loader start the provisional load. And clears it when the load is finished -- since it is available in the document loader. The stored value is useful for the error cases, when the load wasn't successful. The idea is similar to the old implementation, but simpler. This change is related to bug 32723. There, I want to decouple the clearing of the frame from the URL passed in setUrl(), by removing the argument url from the call to DocumentWriter::begin(), and having the value stored in case of fail is useful to implement QWebFrame::url().
Attachments
patch (5.35 KB, patch)
2011-03-06 07:00 PST, Caio Marcelo de Oliveira Filho 		no flags
DetailsFormatted DiffDiff
patch with improved ChangeLog (6.30 KB, patch)
2011-03-06 07:51 PST, Caio Marcelo de Oliveira Filho 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2011-03-06 07:00:18 PST
Created attachment 84888 [details] patch
Kenneth Rohde Christiansen
Comment 2 2011-03-06 07:03:21 PST
Comment on attachment 84888 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=84888&action=review Your changelog does not explain why this new code is equal to the old code, or why the old code is wrong. Are these edge cases not valid anymore? > Source/WebKit/qt/ChangeLog:9 > + so we now it'll be available in the DocumentLoader. know?
Caio Marcelo de Oliveira Filho
Comment 3 2011-03-06 07:51:32 PST
Created attachment 84889 [details] patch with improved ChangeLog
Caio Marcelo de Oliveira Filho
Comment 4 2011-03-06 07:59:34 PST
Antonio, added you to CC since most of the requestedUrl() was implemented by you back in time. Would be very helpful if you could take a look / review this patch, or point some one who would be able to review it. :-)
WebKit Commit Bot
Comment 5 2011-03-10 14:54:20 PST
Comment on attachment 84889 [details] patch with improved ChangeLog Clearing flags on attachment: 84889 Committed r80768: <http://trac.webkit.org/changeset/80768>
WebKit Commit Bot
Comment 6 2011-03-10 14:54:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.