Bug 56837

Summary: Allow WebMediaPlayerClient to call playbackStatechanged in MediaPlayer
Product: WebKit Reporter: Min Qin <qinmin>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jamesr, qinmin, scherkus
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Min Qin
Reported 2011-03-22 09:28:22 PDT
Once we start playing a media url in WebMediaPlayerImpl, m_paused in HTMLMediaElement will always set to true, even if the whole stream has been consumed by the pipeline. This CL allows the WebMediaPlayerClient to inform MediaPlayer that playstate has changed (e.g., pipeline crashed due to some errors and the WebMediaPlayerImpl is in state "paused")
Attachments
Patch (2.66 KB, patch)
2011-03-22 10:01 PDT, Min Qin 		no flags
DetailsFormatted DiffDiff
Patch (2.66 KB, patch)
2011-03-24 16:16 PDT, Min Qin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Min Qin
Comment 1 2011-03-22 10:01:54 PDT
Created attachment 86466 [details] Patch
Andrew Scherkus
Comment 2 2011-03-24 13:56:39 PDT
Comment on attachment 86466 [details] Patch Looks good to me.
James Robinson
Comment 3 2011-03-24 14:02:43 PDT
Can you make a test?
James Robinson
Comment 4 2011-03-24 14:06:15 PDT
Comment on attachment 86466 [details] Patch OK
Min Qin
Comment 5 2011-03-24 16:16:13 PDT
Created attachment 86852 [details] Patch
WebKit Commit Bot
Comment 6 2011-03-24 19:05:50 PDT
The commit-queue encountered the following flaky tests while processing attachment 86852 [details]: http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2011-03-24 19:09:22 PDT
Comment on attachment 86852 [details] Patch Clearing flags on attachment: 86852 Committed r81930: <http://trac.webkit.org/changeset/81930>
WebKit Commit Bot
Comment 8 2011-03-24 19:09:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.