Bug 57142

Summary: [Qt] Change TextureMapperVideoLayer to TextureMapperMediaLayer
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, noam
Priority: P4 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Kwang Yul Seo
Reported 2011-03-25 23:29:01 PDT
[Qt] Build fix: Add ENABLE(VIDEO) guards around texture mapper.
Attachments
Patch (4.54 KB, patch)
2011-03-25 23:32 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (5.20 KB, patch)
2011-03-28 02:39 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2011-03-25 23:32:11 PDT
Created attachment 87012 [details] Patch
Benjamin Poulain
Comment 2 2011-03-26 12:38:54 PDT
Comment on attachment 87012 [details] Patch Stricto sensu, the media content type is video or composited plugin. For me, it looks like the real fix is to change TextureMapperVideoLayer to a TextureMapperMediaLayer where plugins are supported. Alternatively, add a new type for Plugin. No'am, any comment?
Kwang Yul Seo
Comment 3 2011-03-28 02:39:27 PDT
Created attachment 87119 [details] Patch
Benjamin Poulain
Comment 4 2011-03-28 04:37:18 PDT
Comment on attachment 87119 [details] Patch The changes in /texmap/ look correct to me. The change in the Qt implementation does not because of this: class TextureMapperVideoLayerQt : public virtual TextureMapperMediaLayer -> the Qt layer is limited to video. I still r+ because this is improving texture mapper and fixing the Qt layer is a separate problem. But please open a new bug for having a correct implementation of TextureMapperMediaLayer for Qt.
WebKit Commit Bot
Comment 5 2011-03-28 23:30:51 PDT
The commit-queue encountered the following flaky tests while processing attachment 87119 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-03-28 23:32:52 PDT
Comment on attachment 87119 [details] Patch Clearing flags on attachment: 87119 Committed r82199: <http://trac.webkit.org/changeset/82199>
WebKit Commit Bot
Comment 7 2011-03-28 23:32:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.