Bug 57594

Summary: fast/preloader/scan-body-from-head.html is flaky
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-03-31 16:45:56 PDT
The loads in scan-body-from-head.html can load in any order. We can either use setSerializeHTTPLoads to serialize the loads or split the test into three pieces, each with one load. The former reduces coverage because setSerializeHTTPLoads isn't implemented everywhere (which could be fixed), so I favor the latter.
Attachments
Patch (5.95 KB, patch)
2011-03-31 17:59 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-03-31 17:59:50 PDT
Created attachment 87812 [details] Patch
Tony Gentilcore
Comment 2 2011-03-31 18:07:43 PDT
Comment on attachment 87812 [details] Patch Thanks for the fix!
WebKit Commit Bot
Comment 3 2011-03-31 20:44:07 PDT
The commit-queue encountered the following flaky tests while processing attachment 87812 [details]: http/tests/media/video-play-progress.html bug 57607 The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2011-03-31 20:46:07 PDT
Comment on attachment 87812 [details] Patch Clearing flags on attachment: 87812 Committed r82658: <http://trac.webkit.org/changeset/82658>
WebKit Commit Bot
Comment 5 2011-03-31 20:46:12 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2011-03-31 22:42:05 PDT
http://trac.webkit.org/changeset/82658 might have broken SnowLeopard Intel Release (WebKit2 Tests) The following tests are not passing: fast/preloader/scan-body-from-head-import.html fast/preloader/scan-body-from-head-script.html
Adam Barth
Comment 7 2011-03-31 23:07:59 PDT
I added these to the WebKit2 Skipped list b/c it already contains all the other preload scanner tests. WebKit2 is missing the necessary DRT API.
Note You need to log in before you can comment on or make changes to this bug.