Bug 58037

Summary: editing/inserting/6633727.html should be renamed and converted into a dump-as-markup test
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, darin, enrica, eric, justin.garcia, ojan, tkent, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 57872    
Attachments:
Description Flags
cleanup eric: review+, commit-queue: commit-queue-

Ryosuke Niwa
Reported 2011-04-07 06:17:23 PDT
6633727.html checks each condition manually using script-test infrastructure but it does not need to. We should convert it to a dump-as-markup test so that the output can be easily understood. We should also give a more descriptive name.
Attachments
cleanup (8.59 KB, patch)
2011-04-07 06:35 PDT, Ryosuke Niwa 		eric: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-04-07 06:35:05 PDT
Created attachment 88619 [details] cleanup
Eric Seidel (no email)
Comment 2 2011-04-07 08:20:29 PDT
Comment on attachment 88619 [details] cleanup Yay!
Ryosuke Niwa
Comment 3 2011-04-07 08:22:28 PDT
(In reply to comment #2) > (From update of attachment 88619 [details]) > Yay! Thanks for the reviews, Eric.
WebKit Commit Bot
Comment 4 2011-04-07 09:05:03 PDT
Comment on attachment 88619 [details] cleanup Rejecting attachment 88619 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'build-..." exit_code: 2 Last 500 characters of output: ................................................................................................ editing/input ............ editing/inserting ............................................................................................................ editing/inserting/insert-paragraph-at-end-of-line.html -> failed Exiting early after 1 failures. 4924 tests run. 99.91s total testing time 4923 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/8346638
Ryosuke Niwa
Comment 5 2011-04-07 10:03:48 PDT
Committed r83181: <http://trac.webkit.org/changeset/83181>
Note You need to log in before you can comment on or make changes to this bug.