Bug 58573

Summary: Since gcc 4.5.0, windows x64 symbols are not prefixed by underscore
Product: WebKit Reporter: Fridrich Strba <fridrich.strba>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, barraclough, commit-queue, eric, mrobinson, oliver, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Patch
none
Patch none

Fridrich Strba
Reported 2011-04-14 14:34:38 PDT
Fix this in JavaScriptCore
Attachments
Patch (1.49 KB, patch)
2011-04-14 14:38 PDT, Fridrich Strba 		no flags
DetailsFormatted DiffDiff
Patch (1.49 KB, patch)
2011-04-14 15:20 PDT, Fridrich Strba 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fridrich Strba
Comment 1 2011-04-14 14:38:10 PDT
Created attachment 89649 [details] Patch
WebKit Review Bot
Comment 2 2011-04-14 14:40:43 PDT
Attachment 89649 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/jit/JITStubs.cpp:84: Missing space after , [whitespace/comma] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Fridrich Strba
Comment 3 2011-04-14 15:20:07 PDT
Created attachment 89669 [details] Patch
WebKit Commit Bot
Comment 4 2011-04-15 16:33:14 PDT
The commit-queue encountered the following flaky tests while processing attachment 89669 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) http/tests/xmlhttprequest/failed-auth.html bug 51835 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2011-04-15 16:36:07 PDT
Comment on attachment 89669 [details] Patch Clearing flags on attachment: 89669 Committed r84048: <http://trac.webkit.org/changeset/84048>
WebKit Commit Bot
Comment 6 2011-04-15 16:36:11 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2011-04-15 18:21:44 PDT
http://trac.webkit.org/changeset/84048 might have broken WinCairo Debug (Build)
Note You need to log in before you can comment on or make changes to this bug.