Bug 59096

Summary: Split GlyphPage from GlyphPageTreeNode.h into its own header
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: WebCore Misc.Assignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 59085    
Attachments:
Description Flags
Patch krit: review+

Nikolas Zimmermann
Reported 2011-04-21 06:16:37 PDT
Split GlyphPage from GlyphPageTreeNode.h into its own header
Attachments
Patch (23.47 KB, patch)
2011-04-21 06:20 PDT, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2011-04-21 06:20:05 PDT
Created attachment 90522 [details] Patch
Dirk Schulze
Comment 2 2011-04-21 06:32:42 PDT
Comment on attachment 90522 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90522&action=review r=me > Source/WebCore/platform/graphics/GlyphPage.h:77 > + static const size_t size = 256; // Covers Latin-1 in a single page. Can you move this to the top of the file and give it a more meaningful name? Not sure if you have to add a g or k for static consts. > Source/WebCore/platform/graphics/GlyphPage.h:141 > + // Separate arrays, rather than array of GlyphData, to save space. Not sure what you mean here. Can you rephrase it
Nikolas Zimmermann
Comment 3 2011-04-21 06:33:54 PDT
(In reply to comment #2) > (From update of attachment 90522 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90522&action=review > > r=me > > > Source/WebCore/platform/graphics/GlyphPage.h:77 > > + static const size_t size = 256; // Covers Latin-1 in a single page. > > Can you move this to the top of the file and give it a more meaningful name? Not sure if you have to add a g or k for static consts. > > > Source/WebCore/platform/graphics/GlyphPage.h:141 > > + // Separate arrays, rather than array of GlyphData, to save space. > > Not sure what you mean here. Can you rephrase it As discussed on IRC, that requires to change dozens of files, the intent of this patch is only to refactor, not to change any code.
Nikolas Zimmermann
Comment 4 2011-04-21 06:57:52 PDT
Landed in r84490.
Note You need to log in before you can comment on or make changes to this bug.