Bug 59207

Summary: webkit-patch rebaseline is broken
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dpranke, eric, mihaip, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Dimitri Glazkov (Google)
Reported 2011-04-22 10:10:41 PDT
Not sure what's going on yet, filing bug on the spot. Attempting to choose a build from the list makes Python barf: $ webkit-patch rebaseline 11 builders failing Which builder to pull results from: 1. Leopard Intel Release (Tests) 2. Leopard Intel Debug (Tests) 3. SnowLeopard Intel Release (WebKit2 Tests) 4. Windows XP Debug (Tests) 5. GTK Linux 32-bit Release 6. GTK Linux 32-bit Debug 7. GTK Linux 64-bit Debug 8. Qt Linux Release 9. Chromium Win Release (Tests) 10. Chromium Mac Release (Tests) 11. Chromium Linux Release (Tests) Enter a number: 6 Traceback (most recent call last): File "./Tools/Scripts/webkit-patch", line 71, in <module> main() File "./Tools/Scripts/webkit-patch", line 66, in main WebKitPatch(__file__).main() File "/Volumes/Work/WebKitForRolls/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Work/WebKitForRolls/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Work/WebKitForRolls/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 105, in execute for test in self._tests_to_update(build): File "/Volumes/Work/WebKitForRolls/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 92, in _tests_to_update failing_tests = build.layout_test_results().tests_matching_failure_types([test_failures.FailureTextMismatch]) File "/Volumes/Work/WebKitForRolls/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 251, in layout_test_results self._layout_test_results = LayoutTestResults.results_from_string(self._fetch_results_html()) File "/Volumes/Work/WebKitForRolls/Tools/Scripts/webkitpy/common/net/layouttestresults.py", line 136, in results_from_string test_results = ResultsJSONParser.parse_results_json(string) File "/Volumes/Work/WebKitForRolls/Tools/Scripts/webkitpy/common/net/resultsjsonparser.py", line 95, in parse_results_json if not json_results_generator.has_json_wrapper(json_string): File "/Volumes/Work/WebKitForRolls/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py", line 50, in has_json_wrapper return string.startswith(_JSON_PREFIX) and string.endswith(_JSON_SUFFIX) AttributeError: addinfourl instance has no attribute 'startswith'
Attachments
Patch (2.45 KB, patch)
2011-04-22 11:05 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-04-22 10:54:15 PDT
I bet Eric broke it.
Eric Seidel (no email)
Comment 2 2011-04-22 10:54:36 PDT
We just need to wrap that in str()
Eric Seidel (no email)
Comment 3 2011-04-22 10:54:54 PDT
It wasn't tested! :p
Eric Seidel (no email)
Comment 4 2011-04-22 10:55:31 PDT
The testing failure is of course all mine, since this is my new code. Will fix now.
Eric Seidel (no email)
Comment 5 2011-04-22 11:05:52 PDT
Created attachment 90727 [details] Patch
Dimitri Glazkov (Google)
Comment 6 2011-04-22 11:17:50 PDT
Comment on attachment 90727 [details] Patch ok.
WebKit Commit Bot
Comment 7 2011-04-22 13:43:26 PDT
The commit-queue encountered the following flaky tests while processing attachment 90727 [details]: http/tests/xmlhttprequest/remember-bad-password.html bug 51733 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2011-04-22 13:44:57 PDT
Comment on attachment 90727 [details] Patch Clearing flags on attachment: 90727 Committed r84676: <http://trac.webkit.org/changeset/84676>
WebKit Commit Bot
Comment 9 2011-04-22 13:45:02 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 10 2011-04-22 16:18:31 PDT
http://trac.webkit.org/changeset/84676 might have broken GTK Linux 64-bit Debug
Note You need to log in before you can comment on or make changes to this bug.