Bug 59936

Summary: Port Mozilla's IndexedDB tests: inline autoincrement key added on put
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dgrogan, fishd, hans, hclam, pilgrim, tony
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Mark Pilgrim (Google)
Reported 2011-05-02 07:14:46 PDT
Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_objectStore_inline_autoincrement_key_added_on_put.html?force=1 This is a port of a test from Mozilla's IndexedDB test suite. It adds a record with an autoincremented key and then retrieves the record by key and verifies that all data matches expected values. WebKit passes this test.
Attachments
Patch (5.27 KB, patch)
2011-05-02 07:16 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2011-05-02 07:16:59 PDT
Created attachment 91923 [details] Patch
Tony Chang
Comment 2 2011-05-02 12:17:57 PDT
Comment on attachment 91923 [details] Patch OK
WebKit Commit Bot
Comment 3 2011-05-02 13:30:49 PDT
The commit-queue encountered the following flaky tests while processing attachment 91923 [details]: http/tests/xmlhttprequest/remember-bad-password.html bug 51733 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2011-05-02 13:32:28 PDT
Comment on attachment 91923 [details] Patch Clearing flags on attachment: 91923 Committed r85514: <http://trac.webkit.org/changeset/85514>
WebKit Commit Bot
Comment 5 2011-05-02 13:32:33 PDT
All reviewed patches have been landed. Closing bug.
Hin-Chung Lam
Comment 6 2011-05-02 13:49:57 PDT
Committed r85517: <http://trac.webkit.org/changeset/85517>
Hin-Chung Lam
Comment 7 2011-05-02 13:52:08 PDT
webkit-patch land caused this bug to be marked as closed.
Hin-Chung Lam
Comment 8 2011-05-02 13:55:56 PDT
Somehow due to update-webkit mystery I committed this patch for you.
Hin-Chung Lam
Comment 9 2011-05-02 13:56:12 PDT
I mean webkit-patch.
Mark Pilgrim (Google)
Comment 10 2011-05-02 13:59:06 PDT
Well thanks, I guess. :) It was on its way to being committed anyway, so no harm done, I suppose. Mark as RESOLVED FIXED?
Hin-Chung Lam
Comment 11 2011-05-02 13:59:39 PDT
Yes please do.
Tony Chang
Comment 12 2011-05-02 14:03:26 PDT
hclam: webkit-patch was confused because your ChangeLog description was not at the top of the file (maybe it got merged wrong). This change was already landed by the time your change went in.
Note You need to log in before you can comment on or make changes to this bug.