Bug 60519

Summary: IndexedDB: fix up database-quota.html layout test
Product: WebKit Reporter: David Grogan <dgrogan>
Component: New BugsAssignee: David Grogan <dgrogan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, hans, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

David Grogan
Reported 2011-05-09 17:30:49 PDT
IndexedDB: fix up database-quota.html layout test
Attachments
Patch (2.97 KB, patch)
2011-05-09 17:33 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (2.96 KB, patch)
2011-05-12 10:43 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2011-05-09 17:33:46 PDT
Created attachment 92891 [details] Patch
Hans Wennborg
Comment 2 2011-05-10 01:40:24 PDT
Unofficial r+.
Eric Seidel (no email)
Comment 3 2011-05-11 19:33:32 PDT
Who generally reviews database patches?
Nate Chapin
Comment 4 2011-05-12 08:54:29 PDT
Comment on attachment 92891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92891&action=review > LayoutTests/storage/indexeddb/database-quota-expected.txt:28 > -Error function called: (undefined) undefined > +FAIL Error function called: (13) The transaction was aborted, so the request cannot be fulfilled. Is this test genuinely failing, or is this error the correct behavior? I can't tell just from this patch.
David Grogan
Comment 5 2011-05-12 09:59:47 PDT
(In reply to comment #4) > (From update of attachment 92891 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92891&action=review > > > LayoutTests/storage/indexeddb/database-quota-expected.txt:28 > > -Error function called: (undefined) undefined > > +FAIL Error function called: (13) The transaction was aborted, so the request cannot be fulfilled. > > Is this test genuinely failing, or is this error the correct behavior? I can't tell just from this patch. The error is the correct behavior, so it probably shouldn't go in a testFailed. Will re-upload.
David Grogan
Comment 6 2011-05-12 10:43:02 PDT
Created attachment 93302 [details] Patch
WebKit Commit Bot
Comment 7 2011-05-12 11:25:15 PDT
The commit-queue encountered the following flaky tests while processing attachment 93302 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) http/tests/appcache/resource-redirect.html bug 60714 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2011-05-12 11:28:27 PDT
Comment on attachment 93302 [details] Patch Clearing flags on attachment: 93302 Committed r86363: <http://trac.webkit.org/changeset/86363>
WebKit Commit Bot
Comment 9 2011-05-12 11:28:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.