Bug 60592

Summary: Convert RenderFlexibleBox to use IntPoint/IntSize instead of x,y/w,h pairs
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: abarth, commit-queue, eric, simon.fraser, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch none

Emil A Eklund
Reported 2011-05-10 15:41:41 PDT
Convert RenderFlexibleBox to use IntPoint instead of x,y pairs and IntSize instead of width,height pairs.
Attachments
Patch (5.63 KB, patch)
2011-05-10 17:38 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2011-05-10 17:38:55 PDT
Created attachment 93056 [details] Patch
Eric Seidel (no email)
Comment 2 2011-05-10 22:11:08 PDT
Comment on attachment 93056 [details] Patch LGTM. The + IntSize(0, offset) stuff reads a little strangely, but this looks like an improvement.
WebKit Commit Bot
Comment 3 2011-05-11 00:11:29 PDT
Comment on attachment 93056 [details] Patch Clearing flags on attachment: 93056 Committed r86222: <http://trac.webkit.org/changeset/86222>
WebKit Commit Bot
Comment 4 2011-05-11 00:11:33 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2011-05-11 02:07:14 PDT
http://trac.webkit.org/changeset/86222 might have broken Windows XP Debug (Tests)
Darin Adler
Comment 6 2011-05-11 09:20:04 PDT
Comment on attachment 93056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93056&action=review > Source/WebCore/rendering/RenderFlexibleBox.h:53 > + void placeChild(RenderBox* child, IntPoint location); Normally we’d use const IntPoint& instead of just IntPoint to avoid extra constructor overhead.
Eric Seidel (no email)
Comment 7 2011-05-11 10:15:03 PDT
Ah, true. My apologies for not catching that. Thank you Darin.
Emil A Eklund
Comment 8 2011-05-11 10:32:57 PDT
Thanks Darin, I'll upload a patch for that later today, bug 60640.
Note You need to log in before you can comment on or make changes to this bug.