Bug 61574

Summary: Switch MouseRelatedEvent to use IntPoint
Product: WebKit Reporter: Emil A Eklund <eae>
Component: UI EventsAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric, leviw, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
webkit.review.bot: commit-queue-
Patch
none
Patch
none
Patch for landing none

Emil A Eklund
Reported 2011-05-26 15:57:39 PDT
Convert x,y pairs to IntPoint.
Attachments
Patch (22.98 KB, patch)
2011-05-31 11:05 PDT, Emil A Eklund 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (24.55 KB, patch)
2011-05-31 13:57 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch (24.55 KB, patch)
2011-05-31 16:55 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.60 KB, patch)
2011-06-01 11:14 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2011-05-31 11:05:28 PDT
Created attachment 95455 [details] Patch
WebKit Review Bot
Comment 2 2011-05-31 11:19:52 PDT
Comment on attachment 95455 [details] Patch Attachment 95455 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8753418
Emil A Eklund
Comment 3 2011-05-31 13:57:00 PDT
Created attachment 95478 [details] Patch
Emil A Eklund
Comment 4 2011-05-31 16:25:11 PDT
I guess I'll need to include <wtf/MathExtras.h>.h instead of <math.h> to make the windows build happy.
Emil A Eklund
Comment 5 2011-05-31 16:55:53 PDT
Created attachment 95511 [details] Patch
Emil A Eklund
Comment 6 2011-05-31 16:57:05 PDT
Hopefully this should make the windows bot happy. Let's wait and see...
Eric Seidel (no email)
Comment 7 2011-05-31 19:28:35 PDT
Comment on attachment 95511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95511&action=review > Source/WebCore/dom/WheelEvent.cpp:46 > + , m_wheelDelta(IntPoint((int)(wheelTicks.x() * 120), (int)(wheelTicks.y() * 120))) c++ casts, not c. :) > Source/WebCore/platform/graphics/IntPoint.h:99 > + m_x = lroundf((float)m_x * sx); > + m_y = lroundf((float)m_y * sy); Again, c++, not c. Otherwise fine.
Emil A Eklund
Comment 8 2011-06-01 11:09:03 PDT
Thanks Eric. I'll try to remember to use C++ style casts in the future.
Emil A Eklund
Comment 9 2011-06-01 11:14:14 PDT
Created attachment 95630 [details] Patch for landing
WebKit Commit Bot
Comment 10 2011-06-01 16:19:14 PDT
Comment on attachment 95630 [details] Patch for landing Clearing flags on attachment: 95630 Committed r87865: <http://trac.webkit.org/changeset/87865>
WebKit Commit Bot
Comment 11 2011-06-01 16:19:20 PDT
All reviewed patches have been landed. Closing bug.
Emil A Eklund
Comment 12 2011-06-01 16:32:25 PDT
*** Bug 61575 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.